Comments on: Want $500? Help Us Fix Jabberd2! http://metajack.wordpress.com/2008/05/22/want-500-help-us-fix-jabberd2/ a blog about startups and code Thu, 18 Dec 2008 03:41:49 +0000 http://wordpress.com/ hourly 1 By: markdoliner http://metajack.wordpress.com/2008/05/22/want-500-help-us-fix-jabberd2/#comment-318 markdoliner Mon, 03 Nov 2008 08:12:48 +0000 http://metajack.wordpress.com/?p=23#comment-318 Hi again. metajack, I think you've switched to using ejabberd? But I thought I'd leave a follow-up post in case someone else stumbles across this. The two patches on ticket 219 have been committed, along with another change to get rid of another cache which may have contributed to the memory growth you saw. Hi again. metajack, I think you’ve switched to using ejabberd? But I thought I’d leave a follow-up post in case someone else stumbles across this. The two patches on ticket 219 have been committed, along with another change to get rid of another cache which may have contributed to the memory growth you saw.

]]> By: Mark Doliner http://metajack.wordpress.com/2008/05/22/want-500-help-us-fix-jabberd2/#comment-100 Mark Doliner Wed, 04 Jun 2008 22:06:57 +0000 http://metajack.wordpress.com/?p=23#comment-100 @metajack: I've uploaded another patch to the jabberd ticket at http://jabberd2.xiaoka.com/ticket/219 This one is not mysql-specific. I'd love to hear if it helps the problems you're seeing with memory usage. @metajack: I’ve uploaded another patch to the jabberd ticket at http://jabberd2.xiaoka.com/ticket/219 This one is not mysql-specific. I’d love to hear if it helps the problems you’re seeing with memory usage.

]]> By: Mark Doliner http://metajack.wordpress.com/2008/05/22/want-500-help-us-fix-jabberd2/#comment-93 Mark Doliner Wed, 28 May 2008 18:03:16 +0000 http://metajack.wordpress.com/?p=23#comment-93 It's very possible that the the key leaking issue that John mentioned is still a problem... I wasn't extremely thorough, and I'm sure the code has changed a bit since I looked at it late last year. But I would venture to say that it's not likely to be major cause of the memory growth you're seeing. It’s very possible that the the key leaking issue that John mentioned is still a problem… I wasn’t extremely thorough, and I’m sure the code has changed a bit since I looked at it late last year. But I would venture to say that it’s not likely to be major cause of the memory growth you’re seeing.

]]> By: metajack http://metajack.wordpress.com/2008/05/22/want-500-help-us-fix-jabberd2/#comment-85 metajack Tue, 27 May 2008 22:15:49 +0000 http://metajack.wordpress.com/?p=23#comment-85 @Mark: so the key leaking issue that john mentioned isn't really a problem? Unfortunately we do not use mysql, but postgresql. Although perhaps the postgresql backend has a similar leak? I apologize for not specifying that in the bounty above. I'm happy to pay you a partial bounty when smoku commits your patch. @Mark: so the key leaking issue that john mentioned isn’t really a problem? Unfortunately we do not use mysql, but postgresql. Although perhaps the postgresql backend has a similar leak? I apologize for not specifying that in the bounty above. I’m happy to pay you a partial bounty when smoku commits your patch.

]]> By: Mark Doliner http://metajack.wordpress.com/2008/05/22/want-500-help-us-fix-jabberd2/#comment-84 Mark Doliner Tue, 27 May 2008 21:57:12 +0000 http://metajack.wordpress.com/?p=23#comment-84 Tomasz, the lead jabberd2 developer, created a ticket for your bounty at the jabberd2 website. I've attached a patch to the ticket that might help the memory leak if you're using the MySQL storage backend. If it's not too inconvenient, I encourage you to try it out and leave a comment on the ticket with your findings: http://jabberd2.xiaoka.com/ticket/219 Also, in the past I've investigated the usage of many of the hash tables in jabberd2 and most of them appear to free the data they're responsible for in a timely fashion. valgrind's massif tool is a great way to track down the primary users of memory in a program, but it's sometimes hard to use in a production environment, and it's hard to simulate real world traffic in a test environment. Tracking down memory leaks in programs that use memory pools is hard :-( Tomasz, the lead jabberd2 developer, created a ticket for your bounty at the jabberd2 website. I’ve attached a patch to the ticket that might help the memory leak if you’re using the MySQL storage backend. If it’s not too inconvenient, I encourage you to try it out and leave a comment on the ticket with your findings: http://jabberd2.xiaoka.com/ticket/219

Also, in the past I’ve investigated the usage of many of the hash tables in jabberd2 and most of them appear to free the data they’re responsible for in a timely fashion.

valgrind’s massif tool is a great way to track down the primary users of memory in a program, but it’s sometimes hard to use in a production environment, and it’s hard to simulate real world traffic in a test environment.

Tracking down memory leaks in programs that use memory pools is hard :-(

]]> By: john http://metajack.wordpress.com/2008/05/22/want-500-help-us-fix-jabberd2/#comment-83 john Tue, 27 May 2008 12:30:11 +0000 http://metajack.wordpress.com/?p=23#comment-83 Hey Rob, there's this short writeup on the memory leak issue, on the jabberd2 wiki: http://jabberd2.xiaoka.com/wiki/KnownBugs#xhashpoolleakbymisuse Does this seem familiar? It doesn't seem to be on purpose, contrarily to what you're saying. Would you have any insight on the matter? Hey Rob,

there’s this short writeup on the memory leak issue, on the jabberd2 wiki:

http://jabberd2.xiaoka.com/wiki/KnownBugs#xhashpoolleakbymisuse

Does this seem familiar? It doesn’t seem to be on purpose, contrarily to what you’re saying. Would you have any insight on the matter?

]]> By: rob http://metajack.wordpress.com/2008/05/22/want-500-help-us-fix-jabberd2/#comment-82 rob Sat, 24 May 2008 13:25:20 +0000 http://metajack.wordpress.com/?p=23#comment-82 I haven't looked at the code since 2006 so I don't know what's changed since then, but during my watch there was a major memory issue in that the session manager would never release user data that it had previously loaded. There was a really good reason for this at the time that I've forgotten now. Your graphs look rather familiar. Does that issue still exist? --Rob (ex jabberd2 lead developer) I haven’t looked at the code since 2006 so I don’t know what’s changed since then, but during my watch there was a major memory issue in that the session manager would never release user data that it had previously loaded. There was a really good reason for this at the time that I’ve forgotten now. Your graphs look rather familiar. Does that issue still exist?

–Rob (ex jabberd2 lead developer)

]]>